Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: src/objects.cc

Issue 429053005: Avoid one repeated property lookup when computing load ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ic.cc ('K') | « src/objects.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index a846fba4164c9cf3647cbbd0297365cb8bbd03d2..2cfe8b210d272409b1a0435c914cce37908435aa 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -15166,6 +15166,13 @@ PropertyCell* GlobalObject::GetPropertyCell(LookupResult* result) {
}
+PropertyCell* GlobalObject::GetPropertyCell(LookupIterator* lookup) {
Toon Verwaest 2014/07/30 16:54:53 Let the LookupIterator return the cell instead.
Jakob Kummerow 2014/07/31 13:55:51 Done.
+ ASSERT(!HasFastProperties());
+ Object* value = property_dictionary()->ValueAt(lookup->dictionary_entry());
+ return PropertyCell::cast(value);
+}
+
+
Handle<PropertyCell> JSGlobalObject::EnsurePropertyCell(
Handle<JSGlobalObject> global,
Handle<Name> name) {
« src/ic.cc ('K') | « src/objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698