Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: src/x87/stub-cache-x87.cc

Issue 429053005: Avoid one repeated property lookup when computing load ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/stub-cache-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1249 matching lines...) Expand 10 before | Expand all | Expand 10 after
1260 // Get the value from the cell. 1260 // Get the value from the cell.
1261 Register result = StoreIC::ValueRegister(); 1261 Register result = StoreIC::ValueRegister();
1262 if (masm()->serializer_enabled()) { 1262 if (masm()->serializer_enabled()) {
1263 __ mov(result, Immediate(cell)); 1263 __ mov(result, Immediate(cell));
1264 __ mov(result, FieldOperand(result, PropertyCell::kValueOffset)); 1264 __ mov(result, FieldOperand(result, PropertyCell::kValueOffset));
1265 } else { 1265 } else {
1266 __ mov(result, Operand::ForCell(cell)); 1266 __ mov(result, Operand::ForCell(cell));
1267 } 1267 }
1268 1268
1269 // Check for deleted property if property can actually be deleted. 1269 // Check for deleted property if property can actually be deleted.
1270 if (!is_dont_delete) { 1270 if (is_configurable) {
1271 __ cmp(result, factory()->the_hole_value()); 1271 __ cmp(result, factory()->the_hole_value());
1272 __ j(equal, &miss); 1272 __ j(equal, &miss);
1273 } else if (FLAG_debug_code) { 1273 } else if (FLAG_debug_code) {
1274 __ cmp(result, factory()->the_hole_value()); 1274 __ cmp(result, factory()->the_hole_value());
1275 __ Check(not_equal, kDontDeleteCellsCannotContainTheHole); 1275 __ Check(not_equal, kDontDeleteCellsCannotContainTheHole);
1276 } 1276 }
1277 1277
1278 Counters* counters = isolate()->counters(); 1278 Counters* counters = isolate()->counters();
1279 __ IncrementCounter(counters->named_load_global_stub(), 1); 1279 __ IncrementCounter(counters->named_load_global_stub(), 1);
1280 // The code above already loads the result into the return register. 1280 // The code above already loads the result into the return register.
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1390 // ----------------------------------- 1390 // -----------------------------------
1391 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1391 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1392 } 1392 }
1393 1393
1394 1394
1395 #undef __ 1395 #undef __
1396 1396
1397 } } // namespace v8::internal 1397 } } // namespace v8::internal
1398 1398
1399 #endif // V8_TARGET_ARCH_X87 1399 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/stub-cache-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698