Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: src/mips64/stub-cache-mips64.cc

Issue 429053005: Avoid one repeated property lookup when computing load ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1193 matching lines...) Expand 10 before | Expand all | Expand 10 after
1204 } 1204 }
1205 __ Ret(); 1205 __ Ret();
1206 } 1206 }
1207 1207
1208 1208
1209 #undef __ 1209 #undef __
1210 #define __ ACCESS_MASM(masm()) 1210 #define __ ACCESS_MASM(masm())
1211 1211
1212 1212
1213 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal( 1213 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
1214 Handle<PropertyCell> cell, Handle<Name> name, bool is_dont_delete) { 1214 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) {
1215 Label miss; 1215 Label miss;
1216 1216
1217 FrontendHeader(receiver(), name, &miss); 1217 FrontendHeader(receiver(), name, &miss);
1218 1218
1219 // Get the value from the cell. 1219 // Get the value from the cell.
1220 Register result = StoreIC::ValueRegister(); 1220 Register result = StoreIC::ValueRegister();
1221 __ li(result, Operand(cell)); 1221 __ li(result, Operand(cell));
1222 __ ld(result, FieldMemOperand(result, Cell::kValueOffset)); 1222 __ ld(result, FieldMemOperand(result, Cell::kValueOffset));
1223 1223
1224 // Check for deleted property if property can actually be deleted. 1224 // Check for deleted property if property can actually be deleted.
1225 if (!is_dont_delete) { 1225 if (is_configurable) {
1226 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 1226 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
1227 __ Branch(&miss, eq, result, Operand(at)); 1227 __ Branch(&miss, eq, result, Operand(at));
1228 } 1228 }
1229 1229
1230 Counters* counters = isolate()->counters(); 1230 Counters* counters = isolate()->counters();
1231 __ IncrementCounter(counters->named_load_global_stub(), 1, a1, a3); 1231 __ IncrementCounter(counters->named_load_global_stub(), 1, a1, a3);
1232 __ Ret(USE_DELAY_SLOT); 1232 __ Ret(USE_DELAY_SLOT);
1233 __ mov(v0, result); 1233 __ mov(v0, result);
1234 1234
1235 FrontendFooter(name, &miss); 1235 FrontendFooter(name, &miss);
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1371 1371
1372 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1372 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1373 } 1373 }
1374 1374
1375 1375
1376 #undef __ 1376 #undef __
1377 1377
1378 } } // namespace v8::internal 1378 } } // namespace v8::internal
1379 1379
1380 #endif // V8_TARGET_ARCH_MIPS64 1380 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/stub-cache-mips.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698