Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: src/arm64/stub-cache-arm64.cc

Issue 429053005: Avoid one repeated property lookup when computing load ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1177 matching lines...) Expand 10 before | Expand all | Expand 10 after
1188 } 1188 }
1189 __ Ret(); 1189 __ Ret();
1190 } 1190 }
1191 1191
1192 1192
1193 #undef __ 1193 #undef __
1194 #define __ ACCESS_MASM(masm()) 1194 #define __ ACCESS_MASM(masm())
1195 1195
1196 1196
1197 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal( 1197 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
1198 Handle<PropertyCell> cell, Handle<Name> name, bool is_dont_delete) { 1198 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) {
1199 Label miss; 1199 Label miss;
1200 FrontendHeader(receiver(), name, &miss); 1200 FrontendHeader(receiver(), name, &miss);
1201 1201
1202 // Get the value from the cell. 1202 // Get the value from the cell.
1203 Register result = StoreIC::ValueRegister(); 1203 Register result = StoreIC::ValueRegister();
1204 __ Mov(result, Operand(cell)); 1204 __ Mov(result, Operand(cell));
1205 __ Ldr(result, FieldMemOperand(result, Cell::kValueOffset)); 1205 __ Ldr(result, FieldMemOperand(result, Cell::kValueOffset));
1206 1206
1207 // Check for deleted property if property can actually be deleted. 1207 // Check for deleted property if property can actually be deleted.
1208 if (!is_dont_delete) { 1208 if (is_configurable) {
1209 __ JumpIfRoot(result, Heap::kTheHoleValueRootIndex, &miss); 1209 __ JumpIfRoot(result, Heap::kTheHoleValueRootIndex, &miss);
1210 } 1210 }
1211 1211
1212 Counters* counters = isolate()->counters(); 1212 Counters* counters = isolate()->counters();
1213 __ IncrementCounter(counters->named_load_global_stub(), 1, x1, x3); 1213 __ IncrementCounter(counters->named_load_global_stub(), 1, x1, x3);
1214 __ Ret(); 1214 __ Ret();
1215 1215
1216 FrontendFooter(name, &miss); 1216 FrontendFooter(name, &miss);
1217 1217
1218 // Return the generated code. 1218 // Return the generated code.
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
1346 1346
1347 // Miss case, call the runtime. 1347 // Miss case, call the runtime.
1348 __ Bind(&miss); 1348 __ Bind(&miss);
1349 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1349 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1350 } 1350 }
1351 1351
1352 1352
1353 } } // namespace v8::internal 1353 } } // namespace v8::internal
1354 1354
1355 #endif // V8_TARGET_ARCH_ARM64 1355 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698