Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 429053005: Avoid one repeated property lookup when computing load ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1203 matching lines...) Expand 10 before | Expand all | Expand 10 after
1214 } 1214 }
1215 __ Ret(); 1215 __ Ret();
1216 } 1216 }
1217 1217
1218 1218
1219 #undef __ 1219 #undef __
1220 #define __ ACCESS_MASM(masm()) 1220 #define __ ACCESS_MASM(masm())
1221 1221
1222 1222
1223 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal( 1223 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
1224 Handle<PropertyCell> cell, Handle<Name> name, bool is_dont_delete) { 1224 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) {
1225 Label miss; 1225 Label miss;
1226 FrontendHeader(receiver(), name, &miss); 1226 FrontendHeader(receiver(), name, &miss);
1227 1227
1228 // Get the value from the cell. 1228 // Get the value from the cell.
1229 Register result = StoreIC::ValueRegister(); 1229 Register result = StoreIC::ValueRegister();
1230 __ mov(result, Operand(cell)); 1230 __ mov(result, Operand(cell));
1231 __ ldr(result, FieldMemOperand(result, Cell::kValueOffset)); 1231 __ ldr(result, FieldMemOperand(result, Cell::kValueOffset));
1232 1232
1233 // Check for deleted property if property can actually be deleted. 1233 // Check for deleted property if property can actually be deleted.
1234 if (!is_dont_delete) { 1234 if (is_configurable) {
1235 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 1235 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
1236 __ cmp(result, ip); 1236 __ cmp(result, ip);
1237 __ b(eq, &miss); 1237 __ b(eq, &miss);
1238 } 1238 }
1239 1239
1240 Counters* counters = isolate()->counters(); 1240 Counters* counters = isolate()->counters();
1241 __ IncrementCounter(counters->named_load_global_stub(), 1, r1, r3); 1241 __ IncrementCounter(counters->named_load_global_stub(), 1, r1, r3);
1242 __ Ret(); 1242 __ Ret();
1243 1243
1244 FrontendFooter(name, &miss); 1244 FrontendFooter(name, &miss);
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
1377 1377
1378 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1378 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1379 } 1379 }
1380 1380
1381 1381
1382 #undef __ 1382 #undef __
1383 1383
1384 } } // namespace v8::internal 1384 } } // namespace v8::internal
1385 1385
1386 #endif // V8_TARGET_ARCH_ARM 1386 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698