Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 429053002: Use HighResNow whenever possible on Windows. (Closed)

Created:
6 years, 4 months ago by fmeawad
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, tonyg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use HighResNow whenever possible on Windows. Relanding simonjam@'s CL https://codereview.chromium.org/41953002/ to enable QPC. This may result in perf changes, the perf changes may only be in the measurements and not actual regressions. BUG=158234 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M chrome/browser/chrome_browser_main_win.cc View 1 chunk +1 line, -15 lines 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fmeawad
Hi Darin, I am trying to reland simonjam@'s CL to enable QPC on windows. The ...
6 years, 4 months ago (2014-07-30 17:35:07 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
6 years, 4 months ago (2014-07-30 22:35:37 UTC) #2
darin (slow to review)
On 2014/07/30 22:35:37, cpu wrote: > lgtm I defer to Carlos.
6 years, 4 months ago (2014-07-30 22:56:49 UTC) #3
darin (slow to review)
On 2014/07/30 22:56:49, darin wrote: > On 2014/07/30 22:35:37, cpu wrote: > > lgtm > ...
6 years, 4 months ago (2014-07-30 22:57:00 UTC) #4
cpu_(ooo_6.6-7.5)
the trybot seem stuck or something.
6 years, 4 months ago (2014-07-31 21:51:17 UTC) #5
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 4 months ago (2014-07-31 21:51:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/429053002/1
6 years, 4 months ago (2014-07-31 21:54:18 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 01:01:48 UTC) #8
Message was sent while issue was closed.
Change committed as 286928

Powered by Google App Engine
This is Rietveld 408576698