Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 429043003: don't pretend to support dbus on windows in dbus_export.h (Closed)

Created:
6 years, 4 months ago by Mostyn Bramley-Moore
Modified:
6 years, 4 months ago
Reviewers:
keybuk, satorux1
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

don't pretend to support dbus on windows in dbus_export.h Since dbus is only used on linux, don't bother with windows specific symbol exporting. BUG=398644 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M dbus/dbus_export.h View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mostyn Bramley-Moore
@keybuk: PTAL
6 years, 4 months ago (2014-07-29 23:29:21 UTC) #1
Mostyn Bramley-Moore
@keybuk: *ping*
6 years, 4 months ago (2014-08-06 20:49:01 UTC) #2
satorux1
lgtm
6 years, 4 months ago (2014-08-07 04:23:59 UTC) #3
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-07 07:14:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/429043003/1
6 years, 4 months ago (2014-08-07 07:19:14 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 11:46:05 UTC) #6
Message was sent while issue was closed.
Change committed as 288034

Powered by Google App Engine
This is Rietveld 408576698