Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 429013004: Fix typos in num_failures_by_type for json results. (Closed)

Created:
6 years, 4 months ago by Dirk Pranke
Modified:
6 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), dtu, qsr+mojo_chromium.org, telemetry+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix typos in num_failures_by_type for json results. This changes a few occurrences of "Failure" -> "FAIL" and "Pass" -> "PASS" to conform to the doc format. The existing data is not actually being used yet, but the flakiness dashboard needs the correct values. Also fix a typo in run_mojo_python_tests that was preventing us from running individual tests on the command line. R=ojan@chromium.org, viettrungluu@chromium.org, grt@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/test/mini_installer/test_installer.py View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/run_mojo_python_tests.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/unittest/json_results.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Dirk Pranke
6 years, 4 months ago (2014-07-29 21:19:06 UTC) #1
tonyg
tools/telemetry owners lgtm
6 years, 4 months ago (2014-07-29 21:23:35 UTC) #2
ojan
lgtm
6 years, 4 months ago (2014-07-29 23:33:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/429013004/1
6 years, 4 months ago (2014-07-29 23:36:18 UTC) #4
Dirk Pranke
Greg, Trung, can I get OWNERS approvals?
6 years, 4 months ago (2014-07-29 23:38:51 UTC) #5
viettrungluu
On 2014/07/29 23:38:51, Dirk Pranke wrote: > Greg, Trung, can I get OWNERS approvals? LGTM, ...
6 years, 4 months ago (2014-07-30 00:23:04 UTC) #6
grt (UTC plus 2)
On 2014/07/29 23:38:51, Dirk Pranke wrote: > Greg, Trung, can I get OWNERS approvals? You ...
6 years, 4 months ago (2014-07-30 01:12:19 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-30 03:54:09 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 05:37:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/1259)
6 years, 4 months ago (2014-07-30 05:37:31 UTC) #10
grt (UTC plus 2)
The CQ bit was checked by grt@chromium.org
6 years, 4 months ago (2014-07-30 11:11:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/429013004/1
6 years, 4 months ago (2014-07-30 11:12:29 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 14:00:33 UTC) #13
Message was sent while issue was closed.
Change committed as 286504

Powered by Google App Engine
This is Rietveld 408576698