Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: runtime/bin/dartutils.cc

Issue 429013002: Make Dart_LoadLibrary and Dart_LoadSource take line and column offsets like Dart_LoadScript. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/gen_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dartutils.cc
diff --git a/runtime/bin/dartutils.cc b/runtime/bin/dartutils.cc
index 99487f570ec52c3ea0a8a7540ef607dcf64e259f..8b16ab37bd9ad2b179e205bc9de96915b544b58b 100644
--- a/runtime/bin/dartutils.cc
+++ b/runtime/bin/dartutils.cc
@@ -504,7 +504,7 @@ Dart_Handle DartUtils::LibraryTagHandler(Dart_LibraryTag tag,
return Dart_LoadSource(
library,
part_uri_obj,
- Builtin::PartSource(Builtin::kIOLibrary, url_string));
+ Builtin::PartSource(Builtin::kIOLibrary, url_string), 0, 0);
} else {
ASSERT(tag == Dart_kImportTag);
return NewError("Unable to import '%s' ", url_string);
@@ -744,12 +744,12 @@ void FUNCTION_NAME(Builtin_LoadLibrarySource)(Dart_NativeArguments args) {
Dart_Handle result;
if (tag == Dart_kImportTag) {
- result = Dart_LoadLibrary(resolved_script_uri, sourceText);
+ result = Dart_LoadLibrary(resolved_script_uri, sourceText, 0, 0);
} else {
ASSERT(tag == Dart_kSourceTag);
Dart_Handle library = Dart_LookupLibrary(library_uri);
DART_CHECK_VALID(library);
- result = Dart_LoadSource(library, resolved_script_uri, sourceText);
+ result = Dart_LoadSource(library, resolved_script_uri, sourceText, 0, 0);
}
if (Dart_IsError(result)) {
// TODO(hausner): If compilation/loading errors are supposed to
@@ -793,9 +793,9 @@ Dart_Handle DartUtils::LoadSource(Dart_Handle library,
// Load it according to the specified tag.
if (tag == Dart_kImportTag) {
// Return library object or an error string.
- return Dart_LoadLibrary(url, source);
+ return Dart_LoadLibrary(url, source, 0, 0);
} else if (tag == Dart_kSourceTag) {
- return Dart_LoadSource(library, url, source);
+ return Dart_LoadSource(library, url, source, 0, 0);
}
return Dart_NewApiError("wrong tag");
}
« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/gen_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698