runtime/bin/builtin.cc - Issue 429013002: Make Dart_LoadLibrary and Dart_LoadSource take line and column offsets like Dart_LoadScript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/builtin.cc

Issue 429013002: Make Dart_LoadLibrary and Dart_LoadSource take line and column offsets like Dart_LoadScript. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/builtin.cc

diff --git a/runtime/bin/builtin.cc b/runtime/bin/builtin.cc

index 596ea15e6825b3e0a57f3191e9e49533dbc0eab4..d153b11fac23d28935e39d83beb18077c3914bfc 100644

--- a/runtime/bin/builtin.cc

+++ b/runtime/bin/builtin.cc

@@ -87,7 +87,7 @@ void Builtin::SetNativeResolver(BuiltinLibraryId id) {

Dart_Handle Builtin::LoadLibrary(Dart_Handle url, BuiltinLibraryId id) {

- Dart_Handle library = Dart_LoadLibrary(url, Source(id));

+ Dart_Handle library = Dart_LoadLibrary(url, Source(id), 0, 0);

if (!Dart_IsError(library) && (builtin_libraries_[id].has_natives_)) {

// Setup the native resolver for built in library functions.

DART_CHECK_VALID(

« no previous file with comments | « no previous file | runtime/bin/dartutils.cc » ('j') | no next file with comments »