Issue 429005: More tweaks and fixes for extension and bookmark sync promo. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 429005: More tweaks and fixes for extension and bookmark sync promo. ... (Closed)

Created:
11 years, 1 month ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/branches/249/src/

Visibility:
Public.

Description

More tweaks and fixes for extension and bookmark sync promo. Make bookmark sync link start up the sync process. Make the message more aesthetically pleasing. Improve the overall layout of the message; ensure it doesn't overlap the NTP content. Also add a border to the notification line so that it matches the promo line in appearance, and stands out against themes of all colors. BUG=27853, 28047 TEST= start chrome, click on "bookmark sync" in promo message on NTP. chrome should start up the bookmark sync process. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32619 *** REDONE for branch, as original committed version relies on files that will not be merged to 249. *** Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32749

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -37 lines)			Patch
M	chrome/browser/dom_ui/new_tab_ui.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.css	View	5 chunks	+49 lines, -20 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	2 chunks	+15 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	2 chunks	+20 lines, -1 line	0 comments	Download