Issue 429003: Final part of PathString cleanup.

Issue 429003: Final part of PathString cleanup. (Closed)

Created:
11 years, 1 month ago by Munjal (Google)

Modified:
9 years ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Final part of PathString cleanup. BUG=26342 TEST+exist Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32894

Patch Set 5 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -392 lines)			Patch
M	chrome/browser/sync/engine/build_commit_command.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/process_commit_response_command.cc	View	1 2 3	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncapi.cc	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_proto_util.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncer_unittest.cc	View	1 2 3 4	83 chunks	+141 lines, -143 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_util.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncer_util.cc	View	1 2 3	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/protocol/service_constants.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/syncable/directory_backing_store.h	View	1 2 3 4	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/syncable/directory_backing_store.cc	View	1 2 3	4 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.h	View	1 2 3	21 chunks	+24 lines, -24 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable.cc	View	1 2 3	13 chunks	+33 lines, -35 lines	0 comments	Download
M	chrome/browser/sync/syncable/syncable_unittest.cc	View	1 2 3 4	34 chunks	+62 lines, -62 lines	0 comments	Download
M	chrome/browser/sync/util/character_set_converters.h	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/browser/sync/util/character_set_converters.cc	View	1 2 3	1 chunk	+0 lines, -47 lines	0 comments	Download
D	chrome/browser/sync/util/character_set_converters_unittest.cc	View	1 2 3	1 chunk	+0 lines, -32 lines	0 comments	Download
M	chrome/browser/sync/util/query_helpers.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/util/sync_types.h	View	1 2 3	2 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/test/sync/engine/test_directory_setter_upper.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
MM	chrome/test/sync/engine/test_syncable_utils.h	View	1 2 3	2 chunks	+5 lines, -3 lines	0 comments	Download
MM	chrome/test/sync/engine/test_syncable_utils.cc	View	1 2 3	3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

LGTM, four nits. http://codereview.chromium.org/429003/diff/5040/6027 File chrome/browser/sync/engine/syncer_unittest.cc (right): http://codereview.chromium.org/429003/diff/5040/6027#newcode1579 chrome/browser/sync/engine/syncer_unittest.cc:1579: WriteTransaction trans(dir, UNITTEST, __FILE__, __LINE__); Could ...

11 years, 1 month ago (2009-11-23 21:50:29 UTC) #2

Munjal (Google)

11 years, 1 month ago (2009-11-23 23:22:26 UTC) #3

I only see 3 nits.

http://codereview.chromium.org/429003/diff/5040/6027
File chrome/browser/sync/engine/syncer_unittest.cc (right):

http://codereview.chromium.org/429003/diff/5040/6027#newcode1579
chrome/browser/sync/engine/syncer_unittest.cc:1579: WriteTransaction trans(dir,
UNITTEST, __FILE__, __LINE__);
On 2009/11/23 21:50:29, nick wrote:
> Could you indent this too?

Done.

http://codereview.chromium.org/429003/diff/5040/6024
File chrome/browser/sync/syncable/directory_backing_store.h (right):

http://codereview.chromium.org/429003/diff/5040/6024#newcode49
chrome/browser/sync/syncable/directory_backing_store.h:49:
DirectoryBackingStore(const std::string& dir_name,
On 2009/11/23 21:50:29, nick wrote:
> Indented 3 spaces, should be 2.

Done.

http://codereview.chromium.org/429003/diff/5040/6022
File chrome/browser/sync/syncable/syncable_unittest.cc (right):

http://codereview.chromium.org/429003/diff/5040/6022#newcode214
chrome/browser/sync/syncable/syncable_unittest.cc:214: void CreateEntry(const
string &entryname) {
On 2009/11/23 21:50:29, nick wrote:
> "& " not "& " (next 2 methods, too).

Done.

Expand Messages | Collapse Messages