Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 428933003: Extension docs: Remove references to chrome-extension:// being a valid match (Closed)

Created:
6 years, 4 months ago by not at google - send to devlin
Modified:
6 years, 4 months ago
Reviewers:
scheib
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Extension docs: Remove references to chrome-extension:// being a valid match pattern. It actually is, if you have a certain command line flag, but I think we're better off not documenting that. R=scheib@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M chrome/common/extensions/docs/templates/articles/match_patterns.html View 4 chunks +3 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
not at google - send to devlin
6 years, 4 months ago (2014-07-29 17:18:11 UTC) #1
scheib
lgtm
6 years, 4 months ago (2014-07-29 17:29:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/428933003/1
6 years, 4 months ago (2014-07-29 17:31:02 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 17:34:04 UTC) #4
Message was sent while issue was closed.
Change committed as 286242

Powered by Google App Engine
This is Rietveld 408576698