Issue 428913002: Guard against configurations without 'xcode_settings'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428913002: Guard against configurations without 'xcode_settings' (Closed)

Created:
6 years, 4 months ago by Tobias

Modified:
6 years, 4 months ago

Reviewers:
sdefresne, justincohen

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@Fix-Xcode-ninja-workspace-1

Visibility:
Public.

More Reviews

Description

Guard against configurations without 'xcode_settings' e.g. test/generator-output/src/prog1.gyp TEST=Run ./gyptest.py -f xcode-ninja test/generator-output/gyptest-top-all.py Expected to fail with OSError: [Errno 13] Permission denied: 'prog1.ninja.xcworkspace' (instead of KeyError: 'xcode_settings') R=sdefresne@chromium.org, justincohen@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1960

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address nit #

Patch Set 3 : Rebase onto master #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pylib/gyp/xcode_ninja.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sdefresne

lgtm https://codereview.chromium.org/428913002/diff/1/pylib/gyp/xcode_ninja.py File pylib/gyp/xcode_ninja.py (right): https://codereview.chromium.org/428913002/diff/1/pylib/gyp/xcode_ninja.py#newcode83 pylib/gyp/xcode_ninja.py:83: if 'xcode_settings' in old_spec['configurations'][config]: nit: you could use ...

6 years, 4 months ago (2014-07-30 12:07:27 UTC) #1

sdefresne

6 years, 4 months ago (2014-08-01 09:21:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r1960 (presubmit successful).

Expand Messages | Collapse Messages