Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 428893002: Add UseCounters for non-standard, internally unused reflected attributes (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, kenneth.christiansen
Project:
blink
Visibility:
Public.

Description

Add UseCounters for non-standard, internally unused reflected attributes http://whatwg.org/html#htmlhtmlelement http://whatwg.org/html#htmlmetaelement http://whatwg.org/html#htmlobjectelement http://whatwg.org/html#htmltablecellelement None of these attributes are used internally, so the only way sites can depend on them is via these bindings. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/HTMLHtmlElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMetaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableCellElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-07-29 11:44:23 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-29 11:49:18 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-07-29 11:49:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/428893002/1
6 years, 4 months ago (2014-07-29 11:50:50 UTC) #4
commit-bot: I haz the power
Change committed as 179140
6 years, 4 months ago (2014-07-29 12:36:58 UTC) #5
philipj_slow
Well oops, these are actually in the HTML spec, but the links are missing in ...
6 years, 4 months ago (2014-07-30 20:31:35 UTC) #6
philipj_slow
6 years, 4 months ago (2014-07-30 21:35:33 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/427353002/ by philipj@opera.com.

The reason for reverting is: These IDL attributes are actually in the HTML spec:
http://www.whatwg.org/specs/web-apps/current-work/#obsolete.

Powered by Google App Engine
This is Rietveld 408576698