Add LINKER_INITIALIZER marker to MemoryMappedFile::Region::kWholeFile

Add LINKER_INITIALIZER marker to MemoryMappedFile::Region::kWholeFile

This is a follow-up to crrev.com/394313002. const initializers which
rely on the linker zero-initialization should use the LINKER_INITIALIZER
ctor for documentation purposes.
More discussion about this in the linked CL.

BUG=394502
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286423

[Primiano Tucci (use gerrit), 2014-07-29 18:55:29]

This is a trivial 2 line cl.
Following Nico's suggestion and adding the LINKER_INITIALIZER documentation
marker.

[willchan no longer on Chromium, 2014-07-29 19:08:08]

Busy today, on phone. Nico?
On Jul 29, 2014 11:55 AM, <primiano@chromium.org> wrote:

> Reviewers: willchan,
>
> Message:
> This is a trivial 2 line cl.
> Following Nico's suggestion and adding the LINKER_INITIALIZER documentation
> marker.
>
> Description:
> Add LINKER_INITIALIZER marker to MemoryMappedFile::Region::kWholeFile
>
> This is a follow-up to crrev.com/394313002. const initializers which
> rely on the linker zero-initialization should use the LINKER_INITIALIZER
> ctor for documentation purposes.
> More discussion about this in the linked CL.
>
> BUG=394502
>
> Please review this at https://codereview.chromium.org/428883012/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+4, -3 lines):
>   M base/files/memory_mapped_file.h
>   M base/files/memory_mapped_file.cc
>
>
> Index: base/files/memory_mapped_file.cc
> diff --git a/base/files/memory_mapped_file.cc b/base/files/memory_mapped_
> file.cc
> index e9656495844212d1fea11c16cabdca9118e1a540..
> 745a5ff1f4524f944823c244249836b6b52bf9a3 100644
> --- a/base/files/memory_mapped_file.cc
> +++ b/base/files/memory_mapped_file.cc
> @@ -10,9 +10,10 @@
>
>  namespace base {
>
> -const MemoryMappedFile::Region MemoryMappedFile::Region::kWholeFile;
> +const MemoryMappedFile::Region MemoryMappedFile::Region::kWholeFile(
> +    base::LINKER_INITIALIZED);
>
> -MemoryMappedFile::Region::Region() : offset(0), size(0) {
> +MemoryMappedFile::Region::Region(base::LinkerInitialized) : offset(0),
> size(0) {
>  }
>
>  MemoryMappedFile::Region::Region(int64 offset, int64 size)
> Index: base/files/memory_mapped_file.h
> diff --git a/base/files/memory_mapped_file.h b/base/files/memory_mapped_
> file.h
> index dc5680615daf4fb10762ae663f358d0f0f2c7a98..
> 8a7f045f351a0365d496f37f5824607cacfdc12e 100644
> --- a/base/files/memory_mapped_file.h
> +++ b/base/files/memory_mapped_file.h
> @@ -41,7 +41,7 @@ class BASE_EXPORT MemoryMappedFile {
>     private:
>      // This ctor is used only by kWholeFile, to construct a zero-sized
> Region
>      // (which is forbidden by the public ctor) and uniquely identify
> kWholeFile.
> -    Region();
> +    Region(base::LinkerInitialized);
>    };
>
>    // Opens an existing file and maps it into memory. Access is restricted
> to
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-07-29 20:38:43]

lgtm

[benm (inactive), 2014-07-29 21:15:51]

The CQ bit was checked by benm@chromium.org

[commit-bot: I haz the power, 2014-07-29 21:17:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/primiano@chromium.org/428883012/1

[commit-bot: I haz the power, 2014-07-30 02:41:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-07-30 07:02:13]

Change committed as 286423