Issue 428883008: Optimize correct picture in bench_pictures when using --bbh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428883008: Optimize correct picture in bench_pictures when using --bbh (Closed)

Created:
6 years, 4 months ago by robertphillips

Modified:
6 years, 4 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Optimize correct picture in bench_pictures when using --bbh Almost all PictureRenderer::init implementations have the power to overwrite the picture. Retrieve the correct SkPicture from the renderer for optimization. Committed: https://skia.googlesource.com/skia/+/a8f8da0500d9a9a561eb8847292c14d874a31092

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/PictureBenchmark.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 4 months ago (2014-07-29 17:18:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/428883008/1

6 years, 4 months ago (2014-07-29 17:19:22 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-07-29 17:37:07 UTC) #5

Message was sent while issue was closed.

Change committed as a8f8da0500d9a9a561eb8847292c14d874a31092

Expand Messages | Collapse Messages