Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 42883002: Ship DOM/Promises (Closed)

Created:
7 years, 2 months ago by yhirano
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, haraken, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@websocket-inspector-ipc
Visibility:
Public.

Description

Ship DOM/Promises Remove "Promise" runtime enabled flag. Intent-to-Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/0Fs5P6Xgg9g BUG=243345 R=abarth Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160850

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-dedicated-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-shared-worker-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolver.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/FontFaceSet.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Promise.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/imagebitmap/ImageBitmapFactories.cpp View 1 2 3 4 4 chunks +0 lines, -9 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yhirano
7 years, 1 month ago (2013-10-29 08:08:15 UTC) #1
abarth-chromium
lgtm
7 years, 1 month ago (2013-10-29 17:31:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/42883002/160001
7 years, 1 month ago (2013-10-29 17:32:00 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 18:55:11 UTC) #4
Message was sent while issue was closed.
Change committed as 160850

Powered by Google App Engine
This is Rietveld 408576698