Issue 428823003: Revert of After chromium stop using gtk+ for Linux/X11 all not ASCII character in window title start looks li…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428823003: Revert of After chromium stop using gtk+ for Linux/X11 all not ASCII character in window title start looks li… (Closed)

Created:
6 years, 4 months ago by hashimoto

Modified:
6 years, 4 months ago

Reviewers:
dushistov, Elliot Glaysher

CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of After chromium stop using gtk+ for Linux/X11 all not ASCII character in window title start looks li… (https://codereview.chromium.org/414413002/) Reason for revert: Speculative revert to fix "_XTextListToTextProperty" leaking on Linux ASan LSan bots: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/4397 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/5466 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/5797 Original issue's description: > After chromium stop using gtk+ for Linux/X11 all not ASCII character in window title start looks like garbage. This patch fixes this issue, by using algorithm similar to gtk+/Qt's way of setting window titles. > > BUG=378096 > R=erg@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286058 TBR=erg@chromium.org,dushistov@gmail.com NOTREECHECKS=true NOTRY=true BUG=378096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286101

Created: 6 years, 4 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -17 lines)			Patch
	M	AUTHORS	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc	View		1 chunk	+5 lines, -16 lines	0 comments	Download

Total messages: 1 (0 generated)

hashimoto

6 years, 4 months ago (2014-07-29 04:56:02 UTC) #1

Created Revert of After chromium stop using gtk+ for Linux/X11 all not ASCII
character in window title start looks li…