Issue 428823002: Use tighter typing in editing: markup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428823002: Use tighter typing in editing: markup (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
leviw_travelin_and_unemployed, yosin_UTC9

CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Use tighter typing in editing: markup Use tighter typing in editing to increase code readability and avoid unnecessary type checks. This CL focuses on markup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179169

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -100 lines)			Patch
M	Source/core/dom/Element.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/CompositeEditCommand.cpp	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/editing/EditingStyle.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/editing/FormatBlockCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/InsertTextCommand.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/htmlediting.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/editing/htmlediting.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/editing/markup.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/markup.cpp	View	25 chunks	+64 lines, -72 lines	0 comments	Download
M	Source/core/html/HTMLElement.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/428823002/1

6 years, 4 months ago (2014-07-29 18:57:21 UTC) #4

Message was sent while issue was closed.

Change committed as 179169