Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chromeos/ime/input_method_manager.h

Issue 428783008: GetActiveUserProfile() should not be called before profile is initialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment on GetProfile added. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/ime/input_method_manager.h
diff --git a/chromeos/ime/input_method_manager.h b/chromeos/ime/input_method_manager.h
index e237ee9350956072b2b330b786b208d56ff54980..5318ee91b9d495221eb632b7fa29db8fe5557304 100644
--- a/chromeos/ime/input_method_manager.h
+++ b/chromeos/ime/input_method_manager.h
@@ -13,6 +13,8 @@
#include "chromeos/chromeos_export.h"
#include "chromeos/ime/input_method_descriptor.h"
+class Profile;
+
namespace ui {
class Accelerator;
} // namespace ui
@@ -142,11 +144,13 @@ class CHROMEOS_EXPORT InputMethodManager {
// Adds an input method extension. This function does not takes ownership of
// |instance|.
virtual void AddInputMethodExtension(
+ Profile* profile,
const std::string& imm_id,
InputMethodEngineInterface* instance) = 0;
// Removes an input method extension.
- virtual void RemoveInputMethodExtension(const std::string& id) = 0;
+ virtual void RemoveInputMethodExtension(Profile* profile,
+ const std::string& id) = 0;
// Returns a list of descriptors for all Input Method Extensions.
virtual void GetInputMethodExtensions(InputMethodDescriptors* result) = 0;
« no previous file with comments | « chrome/browser/extensions/api/input_ime/input_ime_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698