chrome/browser/chromeos/input_method/input_method_engine_unittest.cc - Issue 428783008: GetActiveUserProfile() should not be called before profile is initialized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

Issue 428783008: GetActiveUserProfile() should not be called before profile is initialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment on GetProfile added. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc b/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

index 8210b1714370c6209492c08f2b1a7e66a339c6cb..a5df161a632924fb0021140edc0454983cf553a5 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc

@@ -175,7 +175,8 @@ class InputMethodEngineTest : public testing::Test {

engine_.reset(new InputMethodEngine());

observer_ = new TestObserver();

scoped_ptr<InputMethodEngineInterface::Observer> observer_ptr(observer_);

- engine_->Initialize(observer_ptr.Pass(),

+ engine_->Initialize(NULL /* profile */,

+ observer_ptr.Pass(),

"",

whitelisted ? kTestExtensionId : kTestExtensionId2,

kTestImeEngineId,