Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 428783007: Add fallback URLFetcher factory to GcdPrivateAPITest. (Closed)

Created:
6 years, 4 months ago by Bernhard Bauer
Modified:
6 years, 4 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add fallback URLFetcher factory to GcdPrivateAPITest. BUG=312328 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287115

Patch Set 1 #

Patch Set 2 : reenable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review.
6 years, 4 months ago (2014-08-01 08:15:45 UTC) #1
Noam Samuel
lgtm
6 years, 4 months ago (2014-08-01 16:53:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/428783007/20001
6 years, 4 months ago (2014-08-01 16:54:29 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 23:18:05 UTC) #4
Message was sent while issue was closed. 
Change committed as 287115

Powered by Google App Engine
This is Rietveld 408576698