Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: third_party/boringssl/BUILD.gn

Issue 428753004: BoringSSL: roll DEPS and enable dynamic visibility. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/boringssl/BUILD.gn
diff --git a/third_party/boringssl/BUILD.gn b/third_party/boringssl/BUILD.gn
index 3308b25f392480e0f7a34d4d1d8be347098bbfed..5a7e49564bb085fdf5c4e446ef9eafcde7f583fb 100644
--- a/third_party/boringssl/BUILD.gn
+++ b/third_party/boringssl/BUILD.gn
@@ -6,6 +6,11 @@
config("openssl_config") {
include_dirs = []
include_dirs += [ "src/include" ]
+ if (is_component_build) {
+ defines += [
+ "BORINGSSL_SHARED_LIBRARY",
+ ]
+ }
}
# Config internal to this build file.
@@ -65,13 +70,9 @@ component("boringssl") {
}
if (is_component_build) {
- if (!is_win) {
- configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
- }
- if (is_posix && !is_mac) {
- # Avoid link failures on Linux x86-64.
- # See http://rt.openssl.org/Ticket/Display.html?id=2466&user=guest&pass=guest
- ldflags = [ "-Wl,-Bsymbolic" ]
- }
+ defines += [
+ "BORINGSSL_SHARED_LIBRARY",
+ "BORINGSSL_IMPLEMENTATION",
davidben 2014/08/01 17:59:47 For consistency, maybe move the BORINGSSL_IMPLEMEN
+ ]
}
}

Powered by Google App Engine
This is Rietveld 408576698