Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 428753003: GN: pass -Wl,--disable-new-dtags on linux so DT_RPATH works (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews, cc-bugs_chromium.org, cjhopman
Project:
chromium
Visibility:
Public.

Description

GN: pass -Wl,--disable-new-dtags on linux so DT_RPATH works Without this shared library dependencies that should be resolved via rpath remain unresolved and component build libraries don't run. Copied from build/common.gypi which is conditional on binutils version, but I'm pretty sure the GN build never runs on older binutils. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/config/gcc/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
6 years, 4 months ago (2014-07-29 01:07:24 UTC) #1
jamesr
Tested by doing an is_component_build = true build and comparing 'ldd out_gn/Component/net_unittests' with and without ...
6 years, 4 months ago (2014-07-29 01:09:57 UTC) #2
brettw
lgtm
6 years, 4 months ago (2014-07-29 20:39:39 UTC) #3
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-07-29 22:13:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/428753003/1
6 years, 4 months ago (2014-07-29 22:14:18 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 03:40:57 UTC) #6
Message was sent while issue was closed.
Change committed as 286399

Powered by Google App Engine
This is Rietveld 408576698