Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 428733010: Prepare for new WebURLRequest::RequestContext enum values. (Closed)

Created:
6 years, 4 months ago by Mike West
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Prepare for new WebURLRequest::RequestContext enum values. BUG=390497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286758

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Everything moved. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/child/web_url_request_util.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Mike West
Fetch added import and imageset contexts. I'd like to add them to blink. This CL ...
6 years, 4 months ago (2014-07-30 12:32:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-30 13:57:26 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-07-30 13:59:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/428733010/1
6 years, 4 months ago (2014-07-30 14:02:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-30 15:12:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 15:23:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/1433)
6 years, 4 months ago (2014-07-30 15:23:08 UTC) #7
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-07-30 16:53:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/428733010/1
6 years, 4 months ago (2014-07-30 16:54:51 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-30 17:44:51 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 17:48:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/1437)
6 years, 4 months ago (2014-07-30 17:48:27 UTC) #12
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-07-31 06:41:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/428733010/20001
6 years, 4 months ago (2014-07-31 06:43:18 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-07-31 09:01:30 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 09:03:50 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/35815) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/1600) chromium_presubmit ...
6 years, 4 months ago (2014-07-31 09:03:51 UTC) #17
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 4 months ago (2014-07-31 09:08:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/428733010/40001
6 years, 4 months ago (2014-07-31 09:10:00 UTC) #19
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 12:23:49 UTC) #20
Message was sent while issue was closed.
Change committed as 286758

Powered by Google App Engine
This is Rietveld 408576698