Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 428733007: Throw an exception when an access check fails and no external callback is installed (Closed)

Created:
6 years, 4 months ago by Jakob Kummerow
Modified:
6 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Throw an exception when an access check fails and no external callback is installed R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22698

Patch Set 1 #

Patch Set 2 : s/ReferenceError/TypeError/ per Toon's wish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -115 lines) Patch
M src/isolate.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/mirror-debugger.js View 4 chunks +16 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 25 chunks +120 lines, -107 lines 0 comments Download
M tools/generate-runtime-tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL. The meat of the change is in isolate.cc; the rest is just updating test ...
6 years, 4 months ago (2014-07-30 09:17:39 UTC) #1
Yang
On 2014/07/30 09:17:39, Jakob wrote: > PTAL. > > The meat of the change is ...
6 years, 4 months ago (2014-07-30 09:21:11 UTC) #2
Jakob Kummerow
6 years, 4 months ago (2014-07-30 09:31:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22698 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698