Issue 428733003: A couple of fixes for using Makefile.standalone on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428733003: A couple of fixes for using Makefile.standalone on Mac. (Closed)

Created:
6 years, 4 months ago by jvoung (off chromium)

Modified:
6 years, 4 months ago

Reviewers:
Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

A couple of fixes for using Makefile.standalone on Mac. (*) PNaCl toolchain_build builds 64-bit libraries for LLVM on Mac. That won't link with subzero code if subzero is built with -m32, so add an option to override the -m32. (*) include locale header (*) Mark xMacroIntegrityCheck unused to avoid clang compiler warning. (*) virtual dtor, for inheritable class (*) Mark compare function const BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=839c4ce

Patch Set 1 #

Patch Set 2 : line wrap #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
M	Makefile.standalone	View	1	2 chunks	+14 lines, -2 lines	0 comments	Download
M	src/IceGlobalContext.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/IceTargetLowering.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/IceTargetLowering.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

6 years, 4 months ago (2014-07-28 22:19:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r839c4ce (presubmit successful).

Expand Messages | Collapse Messages