Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 428643008: Revert of Fix Touch Exploration tests so they don't break eager gesture detection. (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Fix Touch Exploration tests so they don't break eager gesture detection. (https://codereview.chromium.org/428673002/) Reason for revert: The "TouchExplorationTest.RewritesEventsWhenOn" test failing on "Linux Chromium OS ASan LSan Tests (2)": http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%282%29/builds/2152 Original issue's description: > Fix Touch Exploration tests so they don't break eager gesture detection. > > Eager gesture detection is a little bit stricter about requiring > a valid event stream. The touch exploration tests give the > gesture detector an invalid event stream in a few places. > > BUG=398106 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285983 TBR=dmazzoni@chromium.org,lisayin@chromium.org,mfomitchev@chromium.org,tdresser@chromium.org NOTREECHECKS=true NOTRY=true BUG=398106 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286104

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -51 lines) Patch
M chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 1 3 chunks +9 lines, -50 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 1 3 chunks +6 lines, -1 line 0 comments Download
M ui/chromeos/touch_exploration_controller_unittest.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
Created Revert of Fix Touch Exploration tests so they don't break eager gesture detection.
6 years, 4 months ago (2014-07-29 05:11:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/428643008/1
6 years, 4 months ago (2014-07-29 05:12:28 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 05:13:48 UTC) #3
commit-bot: I haz the power
Failed to apply patch for ui/chromeos/touch_exploration_controller_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-07-29 05:13:49 UTC) #4
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-07-29 05:38:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/428643008/90001
6 years, 4 months ago (2014-07-29 05:39:59 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 05:41:43 UTC) #7
Message was sent while issue was closed.
Change committed as 286104

Powered by Google App Engine
This is Rietveld 408576698