Source/web/FullscreenController.cpp - Issue 428633004: Webkit setting for embedders that do not support fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/FullscreenController.cpp

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: nits Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/FullscreenController.cpp

diff --git a/Source/web/FullscreenController.cpp b/Source/web/FullscreenController.cpp

index 7c1215b456474c64686c156ff96f8bda3500f028..6c1aa5fe4a9e3dca85325a4b3473fe0b7566513e 100644

--- a/Source/web/FullscreenController.cpp

+++ b/Source/web/FullscreenController.cpp

@@ -155,9 +155,6 @@ void FullscreenController::didExitFullScreen()

void FullscreenController::enterFullScreenForElement(blink::Element* element)

{

- if (m_webViewImpl->settingsImpl()->disallowFullscreenForNonMediaElements() && !isHTMLMediaElement(element))

- return;

// We are already transitioning to fullscreen for a different element.

if (m_provisionalFullScreenElement) {

m_provisionalFullScreenElement = element;

« Source/core/frame/Settings.in ('K') | « Source/core/frame/Settings.in ('k') | Source/web/WebSettingsImpl.h » ('j') | public/web/WebSettings.h » ('J')