Webkit setting for embedders that do not support fullscreen.

Source/core/frame/Settings.in

Index: Source/core/frame/Settings.in
diff --git a/Source/core/frame/Settings.in b/Source/core/frame/Settings.in
index 2215ed15e2e62e75e9422ff81d40c1e3ee3a2c98..2c3f4d635d2b6064f44c8daee133ee57e1d4e43e 100644
--- a/Source/core/frame/Settings.in
+++ b/Source/core/frame/Settings.in
@@ -269,3 +269,9 @@ deviceScaleAdjustment type=double, initial=1.0, invalidate=TextAutosizing
 # API will return 'false' in that case.
 maxBeaconTransmission type=int, initial=16384
 
+# The following two settings are only exposed for Layout Tests.

[philipj_slow, 2014/07/30 12:11:18]

That's not quite true, they're intended to be set by Android WebView...

[Ignacio Solla, 2014/07/30 14:40:00]

Added "only exposed through Javascript".

[philipj_slow, 2014/07/30 15:47:17]

All settings are exposed in internals.settings for LayoutTests. These settings
seem like most, intended to be set by Chromium, it would be helpful to instead
describe what they do. It sounds like this one would disable the Fullscreen API
entirely, which isn't quite the case.

[Ignacio Solla, 2014/07/31 10:30:51]

Oh, I see, thanks for the clarification!

I have added descriptions now.

+fullscreenEnabled initial=true
+# FIXME: This is a temporary flag and should be removed once

[philipj_slow, 2014/07/30 12:11:18]

Can that ever actually happen. Won't there continue to be apps that don't
implement WebChromeClient.onShowCustomView?

[Ignacio Solla, 2014/07/30 14:40:00]

The fullscreenEnabled setting is for apps that do not implement
onShowCustomView.

The disallowFullscreenForNonMediaElements is for a limitation in the framework.
It will always be true in the WebView (well, until we add support for non-media
elements). The we will have fullscreen for non-media elements unless the app
does not implement onShowCustomView.

[philipj_slow, 2014/07/30 15:47:17]

Let's see if I understand.

http://developer.android.com/reference/android/webkit/WebView.html says "In
order to support inline HTML5 video in your application, you need to have
hardware acceleration turned on, and set a WebChromeClient. For full screen
support, implementations of onShowCustomView(View,
WebChromeClient.CustomViewCallback) and onHideCustomView() are required,
getVideoLoadingProgressView() is optional."

In other words, if onShowCustomView isn't implemented, no fullscreen will work
at all, video or otherwise.

When onShowCustomView is implemented, non-video fullscreen still never works,
but this is something you hope to eventually fix.

Is that right? If so I understand why two settings are needed.

[Ignacio Solla, 2014/07/31 10:30:51]

Exactly, your understanding is correct.

+# the Android WebView supports fullscreen for non-media elements
+# (crbug.com/398485).
+disallowFullscreenForNonMediaElements initial=false