LayoutTests/fullscreen/full-screen-request-not-enabled.html - Issue 428633004: Webkit setting for embedders that do not support fullscreen.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-request-not-enabled.html

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review comments and nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements.html ('K') | « LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements-expected.txt ('k') | LayoutTests/fullscreen/full-screen-request-not-enabled-expected.txt » ('j') | Source/core/frame/Settings.in » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <body>
	falken 2014/07/31 14:53:10 ditto about <body> ditto about <body> Ignacio Solla 2014/08/01 10:02:44 Done. Show quoted text On 2014/07/31 14:53:10, falken wrote: > ditto about <body> Done.
	2 <script src="full-screen-test.js"></script>

	3 <video id="video" width="300"></video>

	4 <div>Tests for the fullScreenEnabled setting which will be set to false

	5 in those platforms where full screen is not supported.

	6 <script>

	7 if (window.internals) {

	8 window.internals.settings.setFullScreenEnabled(false);

	9

	10 waitForEvent(document, 'webkitfullscreenchange', function() {

	11 logResult("Entered full screen.", false);
	falken 2014/07/31 14:53:10 Seems like these arguments are switched? function Seems like these arguments are switched? function logResult(success, text) Also, use single-quotes for consistency with rest of file. Ignacio Solla 2014/08/01 10:02:44 Done. Show quoted text On 2014/07/31 14:53:10, falken wrote: > Seems like these arguments are switched? > > function logResult(success, text) > > Also, use single-quotes for consistency with rest of file. Done.
	12 endTest();

	13 });

	14 waitForEventAndEnd(document, 'webkitfullscreenerror');

	15 runWithKeyDown(function(){document.getElementById('video').webkitRequest FullScreen()});

	16 }

	17 </script>

	18
	falken 2014/07/31 14:53:10 nit: extra line here nit: extra line here Ignacio Solla 2014/08/01 10:02:44 Done. Show quoted text On 2014/07/31 14:53:10, falken wrote: > nit: extra line here Done.
OLD	NEW