LayoutTests/fullscreen/full-screen-request-not-enabled.html - Issue 428633004: Webkit setting for embedders that do not support fullscreen.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-request-not-enabled.html

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements.html ('K') | « LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements-expected.txt ('k') | LayoutTests/fullscreen/full-screen-request-not-enabled-expected.txt » ('j') | Source/core/frame/Settings.in » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <body>

	2 <script src="full-screen-test.js"></script>

	3 <video id="video" width="300"></video>

	4 <div>Tests for the fullscreenEnabled setting which will be set to false

	5 in those platforms where fullscreen is not supported.

	6 <script>

	7 if (window.internals) {

	8 window.internals.settings.setFullscreenEnabled(false);

	9

	10 // Bail out early if the full screen API is not enabled or is missing:

	11 if (Element.prototype.webkitRequestFullScreen == undefined) {

	12 logResult(false, "Element.prototype.webkitRequestFullScreen == undef ined");

	13 endTest();

	14 } else {

	15 waitForEvent(document, 'webkitfullscreenchange', function() {

	16 logResult("Entered full screen.", false);

	17 endTest();

	18 });

	19 waitForEventAndEnd(document, 'webkitfullscreenerror');

	20 runWithKeyDown(function(){document.getElementById('video').webkitReq uestFullScreen()});

	21 }

	22 }

	23 </script>

	24

OLD	NEW