LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements.html - Issue 428633004: Webkit setting for embedders that do not support fullscreen.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements.html

Issue 428633004: Webkit setting for embedders that do not support fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <body>

	2 <script src="full-screen-test.js"></script>

	3 <span id="span" width="300"></span>

	4 <video id="video" width="300"></video>

	5 <div>Tests for the disallowFullscreenForNonMediaElements setting which will be s et

	6 in those platforms where fullscreen for non-media elements is not supported.

	7 <script>

	8 if (window.internals) {

	9 window.internals.settings.setDisallowFullscreenForNonMediaElements(true) ;

	10

	11 // Bail out early if the full screen API is not enabled or is missing:
	philipj_slow 2014/07/30 12:11:18 Why this case? Neither setting hides the API, they Why this case? Neither setting hides the API, they just make it fail. Ignacio Solla 2014/07/30 14:40:00 Removed. Don't need it (I made a copy from another Show quoted text On 2014/07/30 12:11:18, philipj wrote: > Why this case? Neither setting hides the API, they just make it fail. Removed. Don't need it (I made a copy from another test, but I should have removed this).
	12 if (Element.prototype.webkitRequestFullScreen == undefined) {

	13 logResult(false, "Element.prototype.webkitRequestFullScreen == undef ined");

	14 endTest();

	15 } else {

	16 // Fullscreen for non media elements is not supported.

	17 waitForEventOnce(document, 'webkitfullscreenerror');

	18 runWithKeyDown(function(){document.getElementById('span').webkitRequ estFullScreen()})

	19

	20 // Fullscreen for media elements is supported, video in this case.

	21 waitForEventAndEnd(document, 'webkitfullscreenchange');

	22 runWithKeyDown(function(){document.getElementById('video').webkitReq uestFullScreen()});
	philipj_slow 2014/07/30 12:11:18 It would be best to only have one webkitRequestFul It would be best to only have one webkitRequestFullScreen() call in the test. Otherwise it's not clear which request is causing which event. If you want to tests both in a single test then the second request should be made after the first event has been fired. Ignacio Solla 2014/07/30 14:40:00 I've changed it to only run the second step after Show quoted text On 2014/07/30 12:11:18, philipj wrote: > It would be best to only have one webkitRequestFullScreen() call in the test. > Otherwise it's not clear which request is causing which event. If you want to > tests both in a single test then the second request should be made after the > first event has been fired. I've changed it to only run the second step after the first event has been received. I prefer to have both in one test. I think it is clearer and having this in just one place makes it easy to understand what the behaviour should be.
	23 }

	24 }

	25 </script>

	26

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fullscreen/full-screen-request-disallow-for-non-media-elements-expected.txt » ('j') | Source/core/frame/Settings.in » ('J')