Issue 42863003: cros: Default to natural scrolling if the internal diplay is a touchscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 42863003: cros: Default to natural scrolling if the internal diplay is a touchscreen. (Closed)

Created:
7 years, 2 months ago by sadrul

Modified:
7 years, 1 month ago

Reviewers:
oshima

CC:
chromium-reviews, kalyank, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cros: Default to natural scrolling if the internal diplay is a touchscreen. Expose whether a particular display has touch-screen support through gfx::Display, and use that information to turn on natural scrolling on chromeos when the internal display is a touchscreen. BUG=311343 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231079

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -7 lines)			Patch
M	ash/display/display_change_observer_chromeos.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ash/display/display_info.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	ash/display/display_info.cc	View		4 chunks	+8 lines, -2 lines	0 comments	Download
M	ash/display/display_manager.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/events/event_utils.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/events/event_utils.cc	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	ui/gfx/display.h	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	ui/gfx/display.cc	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

7 years, 1 month ago (2013-10-25 19:26:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r231079 (presubmit successful).

Expand Messages | Collapse Messages