Issue 428623002: [Android] Properly set editable flag for insertion handle display

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428623002: [Android] Properly set editable flag for insertion handle display (Closed)

Created:
6 years, 4 months ago by jdduke (slow)

Modified:
6 years, 4 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, raghu

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Properly set editable flag for insertion handle display With the switch to composited seleciton handles (r284491), the determination of whether the focused node is editable was plumbed incorrectly. Switch to the old behavior of using |RenderWidgetHostViewAndroid::TextInputStateChanged()|, ensuring that editability is reset when a navigation event occurs. BUG=397556

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_android.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

aelias@: Could you take a look? This restores the old behavior of determining editability.

6 years, 4 months ago (2014-07-28 15:40:33 UTC) #1

jdduke (slow)

6 years, 4 months ago (2014-07-28 17:33:34 UTC) #2

Please disregard this, I have a follow-up patch that fixes several related
issues, sorry for the noise.

Expand Messages | Collapse Messages