Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 428623002: [Android] Properly set editable flag for insertion handle display (Closed)

Created:
6 years, 4 months ago by jdduke (slow)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, raghu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Properly set editable flag for insertion handle display With the switch to composited seleciton handles (r284491), the determination of whether the focused node is editable was plumbed incorrectly. Switch to the old behavior of using |RenderWidgetHostViewAndroid::TextInputStateChanged()|, ensuring that editability is reset when a navigation event occurs. BUG=397556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jdduke (slow)
aelias@: Could you take a look? This restores the old behavior of determining editability.
6 years, 4 months ago (2014-07-28 15:40:33 UTC) #1
jdduke (slow)
6 years, 4 months ago (2014-07-28 17:33:34 UTC) #2
Please disregard this, I have a follow-up patch that fixes several related
issues, sorry for the noise.

Powered by Google App Engine
This is Rietveld 408576698