Issue 428603002: SkDiscardablePixelRef returns correct indexed color on relock.

Issue 428603002: SkDiscardablePixelRef returns correct indexed color on relock. (Closed)

Created:
6 years, 4 months ago by hal.canary

Modified:
6 years, 4 months ago

Reviewers:
djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

SkDiscardablePixelRef returns correct indexed color on relock. Committed: https://skia.googlesource.com/skia/+/7f8aad84de1661727b467940a4f0e6f6531fc0a1

Patch Set 2 : AnotherPatchSet #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	src/lazy/SkDiscardablePixelRef.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/ImageDecodingTest.cpp	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

djsollen

lgtm https://codereview.chromium.org/428603002/diff/1/tests/ImageDecodingTest.cpp File tests/ImageDecodingTest.cpp (right): https://codereview.chromium.org/428603002/diff/1/tests/ImageDecodingTest.cpp#newcode727 tests/ImageDecodingTest.cpp:727: DEF_TEST(DiscardablePixelRef_SecondLock, r) { add color table to the ...

6 years, 4 months ago (2014-07-28 15:09:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/428603002/20001

6 years, 4 months ago (2014-07-28 15:13:04 UTC) #6

commit-bot: I haz the power

6 years, 4 months ago (2014-07-28 15:23:59 UTC) #7

Message was sent while issue was closed.

Change committed as 7f8aad84de1661727b467940a4f0e6f6531fc0a1

Expand Messages | Collapse Messages