Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 428563002: DevTools: separate style for error message bubble. (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: separate style for error message bubble. This patch separates style used for error message repeat count bubble in console. The style is already used in Resources panel, and will be used later for editor errors. BUG=397217 R=vsevik, apavlov NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179108

Patch Set 1 #

Total comments: 2

Patch Set 2 : console-message-repeat-count -> bubble-repeat-count #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -35 lines) Patch
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 3 chunks +17 lines, -32 lines 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/resourcesPanel.css View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
lushnikov
Please see minor UI changes screenshot in the bug.
6 years, 4 months ago (2014-07-28 09:36:18 UTC) #1
vsevik
This looks like a pure renaming and I don't follow: why resources panel style sheet ...
6 years, 4 months ago (2014-07-29 08:10:22 UTC) #2
vsevik
https://codereview.chromium.org/428563002/diff/1/Source/devtools/front_end/inspectorStyle.css File Source/devtools/front_end/inspectorStyle.css (right): https://codereview.chromium.org/428563002/diff/1/Source/devtools/front_end/inspectorStyle.css#newcode2245 Source/devtools/front_end/inspectorStyle.css:2245: .console-debug-level .console-message-repeat-count { bubble-repeat-count
6 years, 4 months ago (2014-07-29 08:13:58 UTC) #3
lushnikov
https://codereview.chromium.org/428563002/diff/1/Source/devtools/front_end/inspectorStyle.css File Source/devtools/front_end/inspectorStyle.css (right): https://codereview.chromium.org/428563002/diff/1/Source/devtools/front_end/inspectorStyle.css#newcode2245 Source/devtools/front_end/inspectorStyle.css:2245: .console-debug-level .console-message-repeat-count { On 2014/07/29 08:13:58, vsevik wrote: > ...
6 years, 4 months ago (2014-07-29 08:29:25 UTC) #4
vsevik
lgtm
6 years, 4 months ago (2014-07-29 08:44:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/428563002/20001
6 years, 4 months ago (2014-07-29 08:46:23 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 08:48:03 UTC) #7
Message was sent while issue was closed. 
Change committed as 179108

Powered by Google App Engine
This is Rietveld 408576698