Issue 428543002: DevTools: DataGrid: fix "recalculateSiblings" method visibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428543002: DevTools: DataGrid: fix "recalculateSiblings" method visibility. (Closed)

Created:
6 years, 4 months ago by eustas

Modified:
6 years, 4 months ago

Reviewers:
vsevik, lushnikov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: DataGrid: fix "recalculateSiblings" method visibility. BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179138

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	Source/devtools/front_end/profiler/CPUProfileDataGrid.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/devtools/front_end/ui/DataGrid.js	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/428543002/20001

6 years, 4 months ago (2014-07-29 11:00:22 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...

6 years, 4 months ago (2014-07-29 12:11:13 UTC) #6

Message was sent while issue was closed.

Change committed as 179138

Expand Messages | Collapse Messages