Source/core/editing/ApplyStyleCommand.cpp - Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ApplyStyleCommand.cpp

Issue 428533006: Use ContainerNode::hasChildren() instead of firstChild() in conditionals (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ApplyStyleCommand.cpp

diff --git a/Source/core/editing/ApplyStyleCommand.cpp b/Source/core/editing/ApplyStyleCommand.cpp

index a776b09a4cab0cbdeab0caae212435f6fbc85b38..605741114c689ce602c5f1ad3d62cbeab0ca31e4 100644

--- a/Source/core/editing/ApplyStyleCommand.cpp

+++ b/Source/core/editing/ApplyStyleCommand.cpp

@@ -1448,7 +1448,7 @@ void ApplyStyleCommand::applyInlineStyleChange(PassRefPtrWillBeRawPtr<Node> pass

if (isHTMLSpanElement(*containerElement) || (styleContainerIsNotSpan && containerElement->hasChildren()))

styleContainer = toHTMLElement(container);

}

- if (!container->firstChild())

+ if (!container->hasChildren())

break;

startNode = container->firstChild();

endNode = container->lastChild();

« no previous file with comments | « Source/core/dom/TreeWalker.cpp ('k') | Source/core/editing/DeleteSelectionCommand.cpp » ('j') | no next file with comments »