Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 428473002: Remove old API from WebLeakDetector. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
tkent, kouhei (in TOK)
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Remove old API from WebLeakDetector. There is no users of it on either Blink or Chromium. This fixes the FIXME in WebLeakDetector.h. BUG=None TEST=None R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M public/web/WebLeakDetector.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
tkent -> public/OWNERS kouhei -> fyi
6 years, 4 months ago (2014-07-28 01:55:26 UTC) #1
kouhei (in TOK)
lgtm. Thanks! Yes I forgot to remove it
6 years, 4 months ago (2014-07-28 02:00:29 UTC) #2
tkent
lgtm
6 years, 4 months ago (2014-07-28 02:01:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/428473002/1
6 years, 4 months ago (2014-07-28 02:02:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-07-28 02:49:37 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 03:26:10 UTC) #6
Message was sent while issue was closed.
Change committed as 179002

Powered by Google App Engine
This is Rietveld 408576698