Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 428463005: Restore DefineApiAccessorProperty (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Restore DefineApiAccessorProperty BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -8 lines) Patch
M src/apinatives.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M test/mjsunit/runtime-gen/estimatenumberofelements.js View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/generate-runtime-tests.py View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-07-29 08:07:00 UTC) #1
Igor Sheludko
lgtm
6 years, 4 months ago (2014-07-29 08:07:56 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-07-29 08:09:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698