Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 428443002: Cleanup: Rename SkOSPath functions. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 4 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup: Rename SkOSPath functions. Mostly for brevity and matches better with Python: Python | Old C++ | New C++ os.path.join | SkOSPath::SkPathJoin | SkOSPath::Join os.path.basename | SkOSPath::SkBasename | SkOSPath::Basename BUG=None TEST=make all R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/a8e2e1504b9af6ba791637f228debaa23953064a

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : REBASE #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -92 lines) Patch
M bench/DecodeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/ImageDecodeBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/SkipZeroesBench.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M bench/benchmain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DM.cpp View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M dm/DMWriteTask.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M experimental/PdfViewer/chop_transparency_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M experimental/PdfViewer/pdf_viewer_main.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/gm_expectations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gmmain.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M include/core/SkOSFile.h View 2 chunks +3 lines, -2 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleUnpremul.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/utils/SkOSFile.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/DataRefTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DocumentTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/FontHostTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageDecodingTest.cpp View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M tests/OSPathTest.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/StreamTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/CopyTilesRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/Resources.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/bench_pictures_main.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/bench_playback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/bench_record.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/filtermain.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/lua/lua_pictures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/picture_utils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/render_pdfs_main.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tools/skimage_main.cpp View 1 7 chunks +10 lines, -10 lines 0 comments Download
M tools/skpdiff/SkDiffContext.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M tools/skpdiff/skpdiff_util.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (0 generated)
tfarina
6 years, 4 months ago (2014-07-27 22:14:44 UTC) #1
mtklein
lgtm
6 years, 4 months ago (2014-07-28 11:32:14 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-28 12:37:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/428443002/20001
6 years, 4 months ago (2014-07-28 12:37:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 12:37:39 UTC) #5
commit-bot: I haz the power
Presubmit check for 428443002-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 4 months ago (2014-07-28 12:37:41 UTC) #6
tfarina
On 2014/07/28 12:37:41, I haz the power (commit-bot) wrote: > Presubmit check for 428443002-20001 failed ...
6 years, 4 months ago (2014-07-28 16:00:55 UTC) #7
bsalomon
lgtm
6 years, 4 months ago (2014-07-28 16:58:13 UTC) #8
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-28 17:37:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/428443002/20001
6 years, 4 months ago (2014-07-28 17:37:50 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-28 17:37:59 UTC) #11
commit-bot: I haz the power
Failed to apply patch for dm/DM.cpp: While running git apply --index -p1; error: patch failed: ...
6 years, 4 months ago (2014-07-28 17:37:59 UTC) #12
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-29 01:16:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/428443002/40001
6 years, 4 months ago (2014-07-29 01:17:33 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 4 months ago (2014-07-29 01:23:47 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 01:25:37 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot/builds/900)
6 years, 4 months ago (2014-07-29 01:25:38 UTC) #17
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-07-29 02:14:26 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/428443002/60001
6 years, 4 months ago (2014-07-29 02:14:57 UTC) #19
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 02:27:04 UTC) #20
Message was sent while issue was closed.
Change committed as a8e2e1504b9af6ba791637f228debaa23953064a

Powered by Google App Engine
This is Rietveld 408576698