Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1239)

Issue 42843002: Add DBUS_SESSION_BUS_ADDRESS to allowed slave env vars. (Closed)

Created:
7 years, 2 months ago by agable
Modified:
7 years, 2 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M slave/run_slave.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
agable
7 years, 2 months ago (2013-10-25 01:11:06 UTC) #1
Ken Russell (switch to Gerrit)
Thanks. LGTM
7 years, 2 months ago (2013-10-25 01:11:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/42843002/1
7 years, 2 months ago (2013-10-25 01:12:02 UTC) #3
commit-bot: I haz the power
Presubmit check for 42843002-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 2 months ago (2013-10-25 01:12:48 UTC) #4
ghost stip (do not use)
lgtm
7 years, 2 months ago (2013-10-25 01:14:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/42843002/1
7 years, 2 months ago (2013-10-25 01:14:41 UTC) #6
commit-bot: I haz the power
Presubmit check for 42843002-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 2 months ago (2013-10-25 01:15:28 UTC) #7
agable
On 2013/10/25 01:15:28, I haz the power (commit-bot) wrote: > Presubmit check for 42843002-1 failed ...
7 years, 2 months ago (2013-10-25 01:17:16 UTC) #8
iannucci
lgtm
7 years, 2 months ago (2013-10-25 01:19:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/42843002/1
7 years, 2 months ago (2013-10-25 01:19:31 UTC) #10
iannucci
On 2013/10/25 01:19:04, iannucci wrote: > lgtm Do we also need DBUS_SESSION_BUS_PID?
7 years, 2 months ago (2013-10-25 01:19:42 UTC) #11
commit-bot: I haz the power
Change committed as 230897
7 years, 2 months ago (2013-10-25 01:20:23 UTC) #12
Ken Russell (switch to Gerrit)
7 years, 2 months ago (2013-10-25 01:59:55 UTC) #13
Message was sent while issue was closed.
Not sure whether we need DBUS_SESSION_BUS_PID. It isn't set on my desktop Linux
machine. I actually doubt either environment variable is set in the parent
environment of the slave scripts. We'll find out in one of the next runs.

Powered by Google App Engine
This is Rietveld 408576698