Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 428403003: Some tiny cleanups. (Closed)

Created:
6 years, 4 months ago by Wez
Modified:
6 years, 4 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Some tiny cleanups. - Fix EXPECT_EQ() ordering in Capabilities tests. - Move MATCHERs definitions in ClientSession tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287173

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M remoting/base/capabilities_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 2 chunks +13 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Wez
6 years, 4 months ago (2014-08-01 19:07:28 UTC) #1
Jamie
lgtm
6 years, 4 months ago (2014-08-01 19:27:45 UTC) #2
Wez
The CQ bit was checked by wez@chromium.org
6 years, 4 months ago (2014-08-01 19:41:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/428403003/1
6 years, 4 months ago (2014-08-01 19:44:30 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-01 23:44:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-01 23:47:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/36665) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/2107) ios_rel_device ...
6 years, 4 months ago (2014-08-01 23:47:03 UTC) #7
Wez
The CQ bit was checked by wez@chromium.org
6 years, 4 months ago (2014-08-01 23:49:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/428403003/20001
6 years, 4 months ago (2014-08-01 23:50:14 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 07:35:13 UTC) #10
Message was sent while issue was closed.
Change committed as 287173

Powered by Google App Engine
This is Rietveld 408576698