Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: net/socket/ssl_client_socket_pool_unittest.cc

Issue 428373002: Merge 286628 "Merge 286598 "Disable SPDY and QUIC session pooling."" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1985_122/src/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_proxy_client_socket_pool.h" 5 #include "net/http/http_proxy_client_socket_pool.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 780 matching lines...) Expand 10 before | Expand all | Expand 10 after
791 EXPECT_FALSE(handle.socket()); 791 EXPECT_FALSE(handle.socket());
792 EXPECT_FALSE(handle.is_ssl_error()); 792 EXPECT_FALSE(handle.is_ssl_error());
793 const HttpResponseInfo& tunnel_info = handle.ssl_error_response_info(); 793 const HttpResponseInfo& tunnel_info = handle.ssl_error_response_info();
794 EXPECT_EQ(tunnel_info.headers->response_code(), 407); 794 EXPECT_EQ(tunnel_info.headers->response_code(), 407);
795 scoped_ptr<ClientSocketHandle> tunnel_handle( 795 scoped_ptr<ClientSocketHandle> tunnel_handle(
796 handle.release_pending_http_proxy_connection()); 796 handle.release_pending_http_proxy_connection());
797 EXPECT_TRUE(tunnel_handle->socket()); 797 EXPECT_TRUE(tunnel_handle->socket());
798 EXPECT_FALSE(tunnel_handle->socket()->IsConnected()); 798 EXPECT_FALSE(tunnel_handle->socket()->IsConnected());
799 } 799 }
800 800
801 TEST_P(SSLClientSocketPoolTest, IPPooling) { 801 // TODO(rch): re-enable this.
802 TEST_P(SSLClientSocketPoolTest, DISABLED_IPPooling) {
802 const int kTestPort = 80; 803 const int kTestPort = 80;
803 struct TestHosts { 804 struct TestHosts {
804 std::string name; 805 std::string name;
805 std::string iplist; 806 std::string iplist;
806 SpdySessionKey key; 807 SpdySessionKey key;
807 AddressList addresses; 808 AddressList addresses;
808 } test_hosts[] = { 809 } test_hosts[] = {
809 { "www.webkit.org", "192.0.2.33,192.168.0.1,192.168.0.5" }, 810 { "www.webkit.org", "192.0.2.33,192.168.0.1,192.168.0.5" },
810 { "code.google.com", "192.168.0.2,192.168.0.3,192.168.0.5" }, 811 { "code.google.com", "192.168.0.2,192.168.0.3,192.168.0.5" },
811 { "js.webkit.org", "192.168.0.4,192.168.0.1,192.0.2.33" }, 812 { "js.webkit.org", "192.168.0.4,192.168.0.1,192.0.2.33" },
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
929 ssl.channel_id_sent = true; 930 ssl.channel_id_sent = true;
930 ssl.SetNextProto(GetParam()); 931 ssl.SetNextProto(GetParam());
931 TestIPPoolingDisabled(&ssl); 932 TestIPPoolingDisabled(&ssl);
932 } 933 }
933 934
934 // It would be nice to also test the timeouts in SSLClientSocketPool. 935 // It would be nice to also test the timeouts in SSLClientSocketPool.
935 936
936 } // namespace 937 } // namespace
937 938
938 } // namespace net 939 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698