pkg/analysis_services/lib/src/completion/top_level_computer.dart - Issue 428313002: refactor code completion to allow for multiple suggestion computers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_services/lib/src/completion/top_level_computer.dart

Issue 428313002: refactor code completion to allow for multiple suggestion computers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/domain_completion.dart ('K') | « pkg/analysis_services/lib/completion/top_level_computer.dart ('k') | pkg/analysis_services/test/completion/completion_computer_test.dart » ('j') | pkg/analysis_services/test/completion/completion_computer_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_services/lib/src/completion/top_level_computer.dart

diff --git a/pkg/analysis_services/lib/completion/top_level_computer.dart b/pkg/analysis_services/lib/src/completion/top_level_computer.dart

similarity index 91%

rename from pkg/analysis_services/lib/completion/top_level_computer.dart

rename to pkg/analysis_services/lib/src/completion/top_level_computer.dart

index 5416e17631f155b00b5aa2207729aabcebffffb1..8d3c0db96ead95c82333eb49ce67af28b8638cab 100644

--- a/pkg/analysis_services/lib/completion/top_level_computer.dart

+++ b/pkg/analysis_services/lib/src/completion/top_level_computer.dart

@@ -7,13 +7,14 @@ library services.completion.computer.toplevel;

import 'dart:async';

import 'package:analysis_services/completion/completion_suggestion.dart';

+import 'package:analysis_services/completion/completion_computer.dart';

scheglov 2014/07/30 22:44:24 Use Cmd+1 | Sort unit/class members :-)

danrubel 2014/07/31 16:07:24 Ah! I like it. Done. Now if only it was a "do this

import 'package:analysis_services/search/search_engine.dart';

import 'package:analyzer/src/generated/element.dart';

/**

* A computer for `completion.getSuggestions` request results.

-class TopLevelComputer {

+class TopLevelComputer extends CompletionComputer {

final SearchEngine searchEngine;

TopLevelComputer(this.searchEngine);