Issue 428263003: Intersect SkPictureImageFilter bounds against clip bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 428263003: Intersect SkPictureImageFilter bounds against clip bounds. (Closed)

Created:
6 years, 4 months ago by Stephen White

Modified:
6 years, 4 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Intersect SkPictureImageFilter bounds against clip bounds. Intersect SkPictureImageFilter bounds against clip bounds to avoid unnecessary processing. This is how the other filters work (via applyCropRect()), but SkPictureImageFilter maintains its own crop. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3d822c29d4272a6749e59801b202b1ed6d611be8

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	src/effects/SkPictureImageFilter.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	tests/ImageFilterTest.cpp	View		2 chunks	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/428263003/1

6 years, 4 months ago (2014-07-30 21:37:40 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-07-30 21:49:38 UTC) #5

Message was sent while issue was closed.

Change committed as 3d822c29d4272a6749e59801b202b1ed6d611be8

Expand Messages | Collapse Messages