Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 428253008: Revert of Partially move history_types.{cc,h} to //components/history (Closed)

Created:
6 years, 4 months ago by sdefresne
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, browser-components-watch_chromium.org, pedrosimonetti+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Partially move history_types.{cc,h} to //components/history (https://codereview.chromium.org/439713004/) Reason for revert: Missing OWNERS LGTM. Original issue's description: > Partially move history_types.{cc,h} to //components/history > > Move all types from //chrome/browser/history/history_types.{cc,h} that do > not depends on content types to //components/history. > > BUG=371816 > TBR=msw@chromium.org > TBR=jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287333 TBR=msw@chromium.org,jochen@chromium.org,jhawkins@chromium.org,jif@chromium.org,brettw@chromium.org,sky@chromium.org BUG=371816 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+749 lines, -795 lines) Patch
M chrome/browser/history/history_backend.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/history/history_types.h View 5 chunks +408 lines, -1 line 0 comments Download
M chrome/browser/history/history_types.cc View 4 chunks +240 lines, -0 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/history/page_usage_data.h View 1 chunk +70 lines, -0 lines 0 comments Download
A chrome/browser/history/page_usage_data.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/history/top_sites_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/visitsegment_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/jumplist_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_page_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/history.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M components/history/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
D components/history/core/browser/history_types.h View 1 chunk +0 lines, -421 lines 0 comments Download
D components/history/core/browser/history_types.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D components/history/core/browser/page_usage_data.h View 1 chunk +0 lines, -70 lines 0 comments Download
D components/history/core/browser/page_usage_data.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sdefresne
Created Revert of Partially move history_types.{cc,h} to //components/history
6 years, 4 months ago (2014-08-04 17:06:29 UTC) #1
sdefresne
The CQ bit was unchecked by sdefresne@chromium.org
6 years, 4 months ago (2014-08-04 17:07:27 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 4 months ago (2014-08-04 17:07:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/428253008/1
6 years, 4 months ago (2014-08-04 17:08:25 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 00:46:35 UTC) #5
Message was sent while issue was closed.
Change committed as 287420

Powered by Google App Engine
This is Rietveld 408576698