Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 428233003: Fix references to GenericNode::Type that should be templatized (Closed)

Created:
6 years, 4 months ago by titzer
Modified:
6 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix references to GenericNode::Type that should be templatized R=mstarzinger@chromium.org, mstarzinger BUG= Committed: https://code.google.com/p/v8/source/detail?r=22715

Patch Set 1 #

Patch Set 2 : More fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/compiler/generic-node-inl.h View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 4 months ago (2014-07-30 14:37:47 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
6 years, 4 months ago (2014-07-30 14:40:06 UTC) #2
titzer
6 years, 4 months ago (2014-07-30 14:41:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22715 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698